-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: record support in beanpropertyset #19259
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit strange that we have no tests for BeanUtil in the flow-server module, only in flow-data.
Should we have some simple test in server also specifically for the methods we have?
Yeah, noticed the same problem. I think there should be some tests in flow-server as well. Although not sure if tests should be added in context of this issue or in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can generate an internal improvement issue for the tests.
Internal improvement issue for missing tests: #19264 |
This ticket/PR has been released with Vaadin 24.4.0.alpha25 and is also targeting the upcoming stable 24.4.0 version. |
Related to #16879