Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record support in beanpropertyset #19259

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Apr 25, 2024

Related to #16879

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test Results

1 099 files  ± 0  1 099 suites  ±0   1h 23m 12s ⏱️ + 1m 53s
6 999 tests + 1  6 949 ✅ + 1  50 💤 ±0  0 ❌ ±0 
7 373 runs  +28  7 311 ✅ +28  62 💤 ±0  0 ❌ ±0 

Results for commit 7a917b5. ± Comparison against base commit 6317a21.

Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit strange that we have no tests for BeanUtil in the flow-server module, only in flow-data.
Should we have some simple test in server also specifically for the methods we have?

@tepi
Copy link
Contributor Author

tepi commented Apr 26, 2024

Seems a bit strange that we have no tests for BeanUtil in the flow-server module, only in flow-data. Should we have some simple test in server also specifically for the methods we have?

Yeah, noticed the same problem. I think there should be some tests in flow-server as well. Although not sure if tests should be added in context of this issue or in a separate PR.

Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can generate an internal improvement issue for the tests.

@tepi
Copy link
Contributor Author

tepi commented Apr 26, 2024

Internal improvement issue for missing tests: #19264

@tepi tepi merged commit ff10370 into main Apr 26, 2024
26 checks passed
@tepi tepi deleted the feat/record-support-in-beanpropertyset branch April 26, 2024 07:51
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha25 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants