Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use 8080 as the default launch port for opening the browser #19833

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: Use 8080 as the default launch port for opening the browser #19833

merged 1 commit into from
Aug 27, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Aug 27, 2024

Fixes #19832

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@caalador caalador enabled auto-merge (squash) August 27, 2024 06:42
@caalador caalador disabled auto-merge August 27, 2024 06:42
@github-actions GitHub Actions
Copy link

Test Results

1 134 files  ± 0  1 134 suites  ±0   1h 27m 47s ⏱️ - 4m 31s
7 379 tests ± 0  7 329 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 745 runs  +28  7 685 ✅ +28  60 💤 ±0  0 ❌ ±0 

Results for commit 2340b6f. ± Comparison against base commit adf36b0.

@caalador caalador merged commit 20f0f0e into main Aug 27, 2024
25 of 26 checks passed
@caalador caalador deleted the default-open-port branch August 27, 2024 06:59
vaadin-bot pushed a commit that referenced this pull request Aug 27, 2024
@Artur- @vaadin-bot
fix: Use 8080 as the default launch port for opening the browser (#19833
e5b7c4d 
)

Fixes #19832
vaadin-bot added a commit that referenced this pull request Aug 27, 2024
@vaadin-bot @Artur-
fix: Use 8080 as the default launch port for opening the browser (#19833
2151aa7 
) (#19836)

Fixes #19832

Co-authored-by: Artur <artur@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha12 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.4 prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.alpha12 target/24.4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in BrowserLauncher if no server.port is set in application.properties
3 participants
@Artur- @vaadin-bot @caalador