Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: testing "Maven plugin improvements" PR #20776

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

WIP: testing "Maven plugin improvements" PR #20776

wants to merge 22 commits into from

Conversation

mcollovati
Copy link
Collaborator

The purpose of this PR is to test #20695.
DO NOT MERGE.

AB-xdev and others added 19 commits December 23, 2024 10:24
@AB-xdev @mcollovati
Change all occurences of private to protected
c6057e1 
Make everything accessible/overrideable downstram
@AB-xdev @mcollovati
Only use BuildContext where it's needed
2f673b8
@AB-xdev @mcollovati
Assume that BuildContext can be null
8729be1 
Yes not everyone is using Eclipse or want's to have Eclipse specific dependencies...
@AB-xdev @mcollovati
Remove unused class
80601d3
@AB-xdev @mcollovati
Remove productionMode check
6aa43a5 
This check is only needed once during migration and never again.
@AB-xdev @mcollovati
Log accurately how long a goal needs for execution
fdd2fc5
@AB-xdev @mcollovati
Introduce new Reflector system
741d8f8 
* Reflector now uses a Builder-like pattern and can be replaced with a custom implementation if required
* Default implementation only includes/scans only actually used dependencies and not everything else. Special customization may still be required for certain projects
* Replaced``getOrCreateReflector`` with ``getClassFinder``
* Removed some unused methods
* Simplified and extended logging
@AB-xdev @mcollovati
Remove unused code
dad26da
@AB-xdev @mcollovati
Introduce optimization for FlowModeAbstractMojo
560b8eb
@AB-xdev @mcollovati
Cleanup
e82c9e7
@AB-xdev @mcollovati
Introduce optimization for BuildFrontendMojo
d89d02e
@AB-xdev @mcollovati
Cleanup
4200a21
@AB-xdev @mcollovati
Remove not needed dependency
8e8930b 
See #20359
@AB-xdev @mcollovati
Fix tests
4167663
@AB-xdev @mcollovati
Fix test - Use same logik as in plugin
93f3700
@AB-xdev @mcollovati
Also set default values to fields (not just annotations) so that test…
b5aaf33 
…s work
@AB-xdev @mcollovati
Fix format
3b8e836
@AB-xdev @mcollovati
Fix format
139bd11
@mcollovati
fix test
e22ebb5
@mcollovati mcollovati force-pushed the spikes/maven-plugin-improvements branch from 7bea7de to e22ebb5 Compare December 23, 2024 09:24
@vaadin-bot
Copy link
Collaborator

vaadin-bot commented Dec 23, 2024 •
edited
Loading

TC Format Checker Report - 14:32 - 23 - Dec

BLOCKER There are 1 files with format errors

  • To see a complete report of formatting issues, download the differences file

  • To fix the build, please run mvn formatter:format in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn formatter:format

Here is the list of files with format issues in your PR:

flow-server/src/main/java/com/vaadin/flow/internal/hilla/EndpointRequestUtil.java

@mcollovati mcollovati mentioned this pull request Dec 23, 2024
Open
9 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 37m 11s ⏱️ + 2m 45s
7 579 tests ± 0  7 523 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
7 948 runs  +15  7 883 ✅ +15  65 💤 ±0  0 ❌ ±0 

Results for commit 258f7e4. ± Comparison against base commit 09439d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
+1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollovati @vaadin-bot @AB-xdev