Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to specify network concurrency arg for yarn #4135

Merged
merged 1 commit into from
May 21, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented May 18, 2018

Fixes #4122


This change is Reviewable

@caalador
Copy link
Contributor

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


a discussion (no related file):
Seems fine, but would it be possible to drop the formatting changes as the actual changes are hard to see as they are a couple of lines and formatting changes are whole files.

Maven plugin sources should all be formatted to use the same formatting.


Comments from Reviewable

@denis-anisimov
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, caalador wrote…

Seems fine, but would it be possible to drop the formatting changes as the actual changes are hard to see as they are a couple of lines and formatting changes are whole files.

Maven plugin sources should all be formatted to use the same formatting.

Do you have any idea how to do it easily ?
Formatting is already applied and the only way I see is rewrite the code from scratch with formatting disabled.


Comments from Reviewable

@caalador
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, denis-anisimov (Denis) wrote…

Do you have any idea how to do it easily ?
Formatting is already applied and the only way I see is rewrite the code from scratch with formatting disabled.

No good ideas. Let's go with this and create a ticket to format all maven plugin code.


Comments from Reviewable

@denis-anisimov
Copy link
Contributor Author

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


a discussion (no related file):

Previously, caalador wrote…

No good ideas. Let's go with this and create a ticket to format all maven plugin code.

OK.


Comments from Reviewable

@denis-anisimov denis-anisimov merged commit e51488c into master May 21, 2018
@denis-anisimov denis-anisimov deleted the 4122-network-concurrency branch May 21, 2018 12:26
@pekam pekam added this to the 1.0.0.beta12 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants