Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The headerRenderer is ignored when using GridSortColumn #1097

Closed
johannest opened this issue Jul 11, 2023 · 2 comments
Closed

The headerRenderer is ignored when using GridSortColumn #1097

johannest opened this issue Jul 11, 2023 · 2 comments
Labels
enhancement New feature or request hilla Issues related to Hilla

Comments

@johannest
Copy link

Description of the bug

The headerRenderer seems to work only for standard GridColumn, but is ignored when using GridSortColumn

Minimal reproducible example

<Grid items={people}>
              <GridColumn path="id" headerRenderer={() => {
                  return <div>TestHeader1</div>
              }}
              />
              <GridSortColumn path="name"
                              headerRenderer={() => {
                                  return <div>TestHeader2</div>
                              }}
              />
          </Grid>

Expected behavior

The headerRenderer would work also for GridSortColumn.

Actual behavior

The column name is got from the path instead of headerRenderer:
image

Versions:

- Vaadin / Hilla version: 2.0.6, 2.1.2
- Node version: v20.3.1
- Java version: 19
- OS version: MacOS
- Browser version Chrome
- IDE/Editor (if applicable): IntelliJ IDEA
@johannest johannest added bug Something isn't working hilla Issues related to Hilla labels Jul 11, 2023
@web-padawan
Copy link
Member

Thanks for the issue. The current behavior is by design - see the comment in the code about using default header renderer.

@web-padawan web-padawan added enhancement New feature or request and removed bug Something isn't working labels Jul 20, 2023
@cromoteca
Copy link
Contributor

Closing in favor of vaadin/react-components#130.

@cromoteca cromoteca closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hilla Issues related to Hilla
Projects
None yet
Development

No branches or pull requests

3 participants