Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark headerRenderer as unsupported for GridSortColumn #130

Closed
web-padawan opened this issue Jul 20, 2023 · 1 comment · Fixed by #160
Closed

Mark headerRenderer as unsupported for GridSortColumn #130

web-padawan opened this issue Jul 20, 2023 · 1 comment · Fixed by #160
Labels

Comments

@web-padawan
Copy link
Member

Currently, only GridFilterColumn has headerRenderer marked as unsupported:

/*
* According to https://github.com/vaadin/web-components/issues/1485, the
* `headerRenderer` is not allowed for `vaadin-grid-filter-column`.
*/
export type GridFilterColumnProps<TItem> = Partial<

However, the vaadin-grid-sort-column element doesn't support headerRenderer either, see vaadin/hilla#1097

We should update GridSortColumn accordingly to avoid confusion.

@TatuLund
Copy link

TatuLund commented Sep 8, 2023

I studied this more, and found another workaround to set title attribute to sorter.

        <Grid
          ref={(element) => {
            setTimeout(
              () =>
                element
                  ?.getElementsByTagName('vaadin-grid-sorter')[0]
                  .setAttribute('title', 'Sort by last name and first name'),
              100
            );
          }}
         ---
        >
        ...
        </Grid>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants