Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flags for experimental features are ignored for maven goal vaadin:build-frontend #2637

Closed
sahrmann opened this issue Jul 30, 2024 · 3 comments · Fixed by vaadin/flow#19781
Closed

Feature flags for experimental features are ignored for maven goal vaadin:build-frontend #2637

sahrmann opened this issue Jul 30, 2024 · 3 comments · Fixed by vaadin/flow#19781
Assignees
@platosha
Labels
bug Something isn't working hilla Issues related to Hilla Impact: High prerelease version for Vaadin 24.5.0 Released with Vaadin 24.4.11 Released with Vaadin 24.5.0.alpha10 Severity: Major

Comments

@sahrmann
Copy link

Describe the bug

I have a file vaadin-featureflags.properties which contains com.vaadin.experimental.hillaI18n=true. In my local environment, the i18n-instance can be used without problems. However, in my production build, the frontend crashes with the error The Hilla I18n API is currently considered experimental and may change in the future. To use it you need to explicitly enable it in Copilot or by adding com.vaadin.experimental.hillaI18n=true to vaadin-featureflags.properties.

I investigated the issue and while prepare-frontend creates a correct vaadin-featureflags.js, using the goal vaadin:build-frontend creates the file with all features set to false.

Expected-behavior

No response

Reproduction

Create a vaadin-featureflags.properties which contains com.vaadin.experimental.hillaI18n=true and run mvn vaadin:build-frontend. The generated src/main/frontend/generated/vaadin-featureflags.js contains window.Vaadin.featureFlags.hillaI18n = false;.

System Info

Windows/Linux, Vaadin 24.4.4
@sahrmann sahrmann added bug Something isn't working hilla Issues related to Hilla labels Jul 30, 2024
@platosha
Copy link
Contributor

platosha commented Aug 8, 2024

Does reproduce for me, also when running mvn package -Pproduction. Investigating for the cause.

@platosha platosha self-assigned this Aug 8, 2024
platosha added a commit to vaadin/flow that referenced this issue Aug 13, 2024
@platosha
fix: use URLClassLoader with ResourceProvider in Maven plugins
9aca87a 
Fixes vaadin/hilla#2637

ResourceProvider ignored the actual project's resources when using the default ClassLoader. This resulted in loading `vaadin-featureflags.properties` from the vaadin-dev-bundle jar, even though there is a file in the project.
platosha added a commit to vaadin/flow that referenced this issue Aug 13, 2024
@platosha
fix: use URLClassLoader with ResourceProvider in Maven plugins
b323b62 
Fixes vaadin/hilla#2637

ResourceProvider ignored the actual project's resources when using the default ClassLoader. This resulted in loading `vaadin-featureflags.properties` from the vaadin-dev-bundle jar, even though there is a file in the project.
@platosha platosha mentioned this issue Aug 13, 2024
Merged
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha10 and is also targeting the upcoming stable 24.5.0 version.

caalador pushed a commit to vaadin/flow that referenced this issue Aug 21, 2024
@platosha @caalador
fix: use URLClassLoader with ResourceProvider in Maven plugins (#19781)
f70d7fd 
Fixes vaadin/hilla#2637

ResourceProvider ignored the actual project's resources when using the default ClassLoader. This resulted in loading `vaadin-featureflags.properties` from the vaadin-dev-bundle jar, even though there is a file in the project.
@caalador caalador mentioned this issue Aug 21, 2024
Merged
platosha added a commit to vaadin/flow that referenced this issue Aug 23, 2024
@caalador @platosha
fix: use URLClassLoader with ResourceProvider in Maven plugins (#19781)…
e748c20 
… (#19810)

Fixes vaadin/hilla#2637

ResourceProvider ignored the actual project's resources when using the default ClassLoader. This resulted in loading `vaadin-featureflags.properties` from the vaadin-dev-bundle jar, even though there is a file in the project.

Co-authored-by: Anton Platonov <anton@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@platosha platosha

Labels
bug Something isn't working hilla Issues related to Hilla Impact: High prerelease version for Vaadin 24.5.0 Released with Vaadin 24.4.11 Released with Vaadin 24.5.0.alpha10 Severity: Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use URLClassLoader with ResourceProvider in Maven plugins vaadin/flow
3 participants
@platosha @sahrmann @vaadin-bot