Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): Fix form validation does not work in Kotlin. #2529

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Yue-plus
Copy link

@Yue-plus Yue-plus commented Jun 11, 2024

Description

  • -Xjsr305=strict: This argument changes how the Kotlin compiler handles nullability annotations. The strict mode means that the compiler will strictly check nullability annotations and give a warning or error when it finds a problem.
  • -Xemit-jvm-type-annotations: This argument makes the Kotlin compiler emit JVM type annotations into the bytecode.

Fixes #2343

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

platosha
platosha previously approved these changes Jun 13, 2024
auto-merge was automatically disabled June 14, 2024 16:11

Head branch was pushed to by a user without write access

@Yue-plus Yue-plus requested a review from platosha June 14, 2024 16:15
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Yue-plus
Copy link
Author

I apologize for my previous misunderstanding of the Groovy programming language. I was not aware that Groovy allows direct assignment to lists without the need to call the addAll method. I have tested these changes locally and confirmed their correctness. Please review this PR again, thank you.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form validation does not work in Kotlin.
3 participants