Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add jackson dependency to dependencyManagement (24.4) #2550

Closed
wants to merge 6 commits into from

Conversation

ZheSun88
Copy link
Contributor

those dependencies have been used in hilla-endpoint without any <version> tag. https://github.com/vaadin/hilla/blob/24.4/packages/java/endpoint/pom.xml#L124...L143

Adding them to dependencymangement section to root pom

@ZheSun88 ZheSun88 changed the title chore: add jackson dependency to dependencyManagement chore: add jackson dependency to dependencyManagement (24.4) Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (24.4@135774e). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.4    #2550   +/-   ##
=======================================
  Coverage        ?   95.05%           
=======================================
  Files           ?       66           
  Lines           ?     4573           
  Branches        ?      664           
=======================================
  Hits            ?     4347           
  Misses          ?      181           
  Partials        ?       45           
Flag Coverage Δ
unittests 95.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 21, 2024

@ZheSun88 ZheSun88 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants