feat: add support for Daily Active User feature #2649
Conversation
|
This is a draft PR, just to share a potential solution for DAU integration in Hilla and start a discussion. |
| if (service != null) { | ||
| DAUUtils.TrackableOperation.INSTANCE.execute(() -> { | ||
| service.requestStart(vaadinRequest, vaadinResponse); | ||
| DAUUtils.applyEnforcement(vaadinRequest, unused -> true); |
There was a problem hiding this comment.
Once the Flow PR will be merged, this should be changed int this way
if (DAUUtils.isDauEnabled(service)) {
FlowDauIntegration.applyEnforcement(vaadinRequest, unused -> true)
}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2649 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 78 78
Lines 2454 2454
Branches 634 634
=======================================
Hits 2262 2262
Misses 145 145
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
License checker was change to provided scope in flow-server which broke some tests. Added dependency back in test scope only.
Added new serveEndpoint with a response and kept old for backwards compatibility.
DAUUtils.trackDAU(VaadinService, HttpServletRequest, HttpServletResponse) is helper that does same things as EndpointController before, but code is moved to flow codebase.
|
Requires now also vaadin/flow#19782. |
packages/java/endpoint/src/main/java/com/vaadin/hilla/EndpointController.java
Show resolved
Hide resolved
|
|
This ticket/PR has been released with Hilla 24.5.0.alpha9 and is also targeting the upcoming stable 24.5.0 version. |
Adds support for Daily Active User feature for DAU enabled production build artifacts.