feat(push): add callback on subscription lost event #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
==========================================
- Coverage 94.53% 94.48% -0.05%
==========================================
Files 81 81
Lines 2635 2648 +13
Branches 664 666 +2
==========================================
+ Hits 2491 2502 +11
- Misses 140 142 +2
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-Flux-that-no-longer-exists
cromoteca
changed the title
…-Flux-that-no-longer-exists
…-Flux-that-no-longer-exists
cromoteca
changed the title
…-Flux-that-no-longer-exists
…-Flux-that-no-longer-exists
…-Flux-that-no-longer-exists
…-Flux-that-no-longer-exists
cromoteca
changed the title
…-Flux-that-no-longer-exists
|
taefi
approved these changes
Sep 20, 2024
taefi
reviewed
Sep 20, 2024
Comment on lines
+234
to
+238
| throw new Error( | ||
| endpointInfo | ||
| ? `Error in ${endpointInfo.endpointName}.${endpointInfo.methodName}(${JSON.stringify(endpointInfo.params)}): ${message.message}` | ||
| : `Error in unknown subscription: ${message.message}`, | ||
| ); |
There was a problem hiding this comment.
Minor: A test can be added to cover this change.
platosha
approved these changes
Sep 23, 2024
platosha
deleted the
fix/2716/push-client-tries-to-reconnect-to-a-Flux-that-no-longer-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to define a behavior for when the
reopenedevent happens on the client.The new
onSubscriptionLostcallback can be used to perform an action when the websocket is reopened, but there's no longer a Flux connected to the subscription. Based on the return value of that callback, automatic resubscription can be performed.Fixes #2716