Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not submit autoform on key-down if pressed in textarea #2741

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

krissvaa
Copy link
Contributor

Fixes #2697

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (4125dac) to head (7591ff0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2741   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          81       81           
  Lines        2633     2635    +2     
  Branches      680      681    +1     
=======================================
+ Hits         2489     2491    +2     
  Misses        140      140           
  Partials        4        4           
Flag Coverage Δ
unittests 94.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 18, 2024

@platosha platosha merged commit 224b9ae into main Sep 18, 2024
15 checks passed
@platosha platosha deleted the fix/autoform-textarea-returnkey branch September 18, 2024 15:47
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoForm submits when pressing Return key, even in TextArea fields
3 participants