Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change window and document DOM access to self checks for SW context #2900

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

krissvaa
Copy link
Contributor

Fixes #2867

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (02ae959) to head (3107c8f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/ts/frontend/src/Connect.ts 50.00% 0 Missing and 1 partial ⚠️
packages/ts/frontend/src/CookieManager.ts 0.00% 0 Missing and 1 partial ⚠️
packages/ts/frontend/src/FluxConnection.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2900      +/-   ##
==========================================
- Coverage   92.70%   92.60%   -0.11%     
==========================================
  Files          83       83              
  Lines        2851     2852       +1     
  Branches      739      742       +3     
==========================================
- Hits         2643     2641       -2     
  Misses        157      157              
- Partials       51       54       +3     
Flag Coverage Δ
unittests 92.60% <40.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krissvaa krissvaa force-pushed the fix/sw-context-access branch from f5f6170 to cf3a028 Compare November 11, 2024 17:11
Lodin
Lodin previously requested changes Nov 14, 2024
packages/ts/frontend/src/Connect.ts Outdated Show resolved Hide resolved
@Lodin Lodin requested a review from platosha November 25, 2024 11:05
Copy link

@platosha platosha enabled auto-merge (squash) November 25, 2024 14:48
@platosha platosha merged commit c2ff61b into main Nov 25, 2024
13 of 15 checks passed
@platosha platosha deleted the fix/sw-context-access branch November 25, 2024 14:49
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.6.0.beta2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA endpoint errors while called from SW
4 participants