Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes kit demo for Vaadin 24 #84

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SebastianKuehnau
Copy link

Description

I created a running demo for Vaadin 24 and fixed the following issues:

  1. registry definition (remove localhost:5001) for the image from app-v*.yml files.
  2. set the default image pull policy to always in the app-v*.yml files (imagePullPolicy: Always)
  3. remove line-awesome and replace it
  4. update exampledata library (org.vaadin.artur.exampledata.exampledata:3.4.0)
  5. add snakeyml library to make application.yml file readable
  6. make the contact form sessions replicatable

Fixes # (issue)

  1. update the registry configuration
  2. update the image pull policy definition
  3. removed
  4. updated to com.vaadin.exampledata:6.2.0
  5. added
  6. fixed issues in the ContactForm and in the application.yml file

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@manolo manolo requested a review from heruan September 21, 2023 06:35
Copy link
Member

@heruan heruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for reviewing nine months later, this kinda slipped from our hands when the new 6-w project started. It would still be useful to update the demo to the latest Flow version, if you'd like to fix the current conflicts!

@heruan heruan marked this pull request as draft March 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants