Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Button-bar" mode in MenuBar #6552

Open
4 of 14 tasks
rolfsmeds opened this issue Jun 28, 2024 · 0 comments
Open
4 of 14 tasks

"Button-bar" mode in MenuBar #6552

rolfsmeds opened this issue Jun 28, 2024 · 0 comments
Labels
acceptance criteria used for the acceptance criteria checklist DS Design System feature (e.g. component)

Comments

@rolfsmeds
Copy link
Collaborator

rolfsmeds commented Jun 28, 2024

Description

An interaction mode for the MenuBar that makes top-level menu items (menu bar buttons) traversable by tab instead of arrow keys (i.e. disabling roving tabindex)

Use cases

As a user
I expect to traverse between buttons in a MenuBar with tab
So that I can traverse them the same way as normal buttons

Acceptance criteria

  • API for enabling the "tab navigation" mode, e.g.
    • WC / React: tabNavigation property
    • Flow: setTabNavigation(boolean)
  • Disables roving tabindex, setting a static tabindex="0" on all vaadin-menu-bar-buttons (except disabled ones)
  • Replaces role="menubar" with role="group" on vaadin-menu-bar
  • Replaces role="menuitem" with role="button" on vaadin-menu-bar-button

General criteria

  • APIs reviewed
  • Design
  • Performance
  • UX/DX tests in Alpha
  • Documentation:
  • How to test?
  • Limitations:

Security

  • Security implications have been taken into account (elaborate or link to product security requirement specification if there are implications)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance criteria used for the acceptance criteria checklist DS Design System feature (e.g. component)
Projects
None yet
Development

No branches or pull requests

1 participant