Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setTabNavigation/isTabNavigation #6554

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

jcgueriaud1
Copy link
Contributor

Description

Add the getters and setters for the html tabNavigation attribute added in the web component.

Fixes vaadin/web-components#7525

Acceptance criteria vaadin/platform#6552

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

@web-padawan web-padawan merged commit f712143 into main Aug 20, 2024
5 checks passed
@web-padawan web-padawan deleted the menu-bar-tab-navigation branch August 20, 2024 08:23
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants