Updated comments about bug LPS-107438

vaadin · Jan 14, 2022 · 76b695e · 76b695e
1 parent 11fef21
commit 76b695e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/vaadin-portlet/src/main/java/com/vaadin/flow/portal/VaadinLiferayPortlet.java b/vaadin-portlet/src/main/java/com/vaadin/flow/portal/VaadinLiferayPortlet.java
@@ -22,7 +22,10 @@ public abstract class VaadinLiferayPortlet<C extends Component>
     @Override
     public void renderHeaders(HeaderRequest request, HeaderResponse response) {
         // Skip most of renderHeaders for liferay portlets as it is called inconsistently between different versions (7.2, 7.3).
-        // - response.addDependency() won't work (ref: https://issues.liferay.com/browse/LPS-107438).
+        // - response.addDependency() won't work with all versions
+        // (ref:https://issues.liferay.com/browse/LPS-107438)
+        // Update: LPS-107438 testcase works with 7.3.10 after removing
+        // PortletHub dependency from portlet.xml.
         // - injected scripts may or may not actually appear on the page, and they are processed as XML (?)
         // -> do the injection in doHeaders instead