fix: make resolver commands argument optional

vaadin · Oct 7, 2024 · d758d3b · d758d3b
1 parent cfe7064
commit d758d3b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/resolver/resolveRoute.ts b/src/resolver/resolveRoute.ts
@@ -9,12 +9,10 @@
 import type { ActionResult, AnyObject, MaybePromise, RouteContext } from './types.js';
 import { isFunction } from './utils.js';
 
-// eslint-disable-next-line @typescript-eslint/no-invalid-void-type
 export default function resolveRoute<T, R extends AnyObject, C extends AnyObject>(
   context: RouteContext<T, R, C>,
 ): MaybePromise<ActionResult<T | RouteContext<T, R, C>>> {
   if (isFunction(context.route.action)) {
-    // @ts-expect-error: ignore "never" type here
     return context.route.action(context);
   }
   return undefined;

diff --git a/src/resolver/types.d.ts b/src/resolver/types.d.ts
@@ -25,7 +25,7 @@ export type BasicRoutePart<T, R extends AnyObject, C extends AnyObject> = Readon
   action?(
     this: Route<T, R, C>,
     context: RouteContext<T, R, C>,
-    commands: never,
+    commands?: never,
   ): MaybePromise<ActionResult<T | RouteContext<T, R, C>>>;
 }> & {
   __children?: ReadonlyArray<Route<T, R, C>>;