Function removeDomNodes removes only half expected children

[schoenobates]

The indexing in removeDomNodes is incorrect - as the nodes are removed the nodes.length decreases meaning it will remove half the nodes expected. The nodes list is an HTMLCollection which is a live reflection on the parents children.

function removeDomNodes(nodes) {
  if (nodes && nodes.length) {
    const parent = nodes[0].parentNode;

    for (let i = 0; i < nodes.length; i++) {
      parent.removeChild(nodes[i]);
    }
  }
}

This could be changed to:

function removeDomNodes(nodes) {
 if (nodes && nodes.length) {
   const parent = nodes[0].parentNode;
   const childrenCount = nodes.length - 1;

   for (let i = childrenCount; i >= 0; i--) {
     parent.removeChild(nodes[i]);
   }
 }
}

So should also work if a plain array is passed in...