Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removeDomNodes with HTMLCollection #583

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

joheriks
Copy link

@joheriks joheriks commented Mar 12, 2021

Fixes #523. Also converted to static helper instead of scoped function for testability.

Also converted to static helper instead of scoped function for testability.
@joheriks joheriks added the hilla label Mar 12, 2021
@platosha platosha merged commit 216c126 into master Mar 12, 2021
@platosha platosha deleted the joheriks/523-html-collection branch March 12, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function removeDomNodes removes only half expected children
2 participants