Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for route.bundle #464

Merged
merged 5 commits into from
Jan 29, 2021
Merged

Drop support for route.bundle #464

merged 5 commits into from
Jan 29, 2021

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented May 26, 2020 •
edited
Loading

Fix #442

The bundle size changes from 7.74KB to 7.36KB 🎉

Note: This is a breaking change.

This change is Reviewable

@abdonrd abdonrd mentioned this pull request May 26, 2020
Open
@abdonrd abdonrd marked this pull request as ready for review May 26, 2020 11:08
@haijian-vaadin
Copy link
Contributor

Thanks a lot @abdonrd for the contribution, it's really a nice PR. Sorry for keeping you waiting, we are currently focusing on a new Vaadin release, once we get that finished, we will merge your PRs(this one and #450) and make a new router release.

@platosha platosha self-assigned this Jan 29, 2021
@platosha platosha removed their assignment Jan 29, 2021
@haijian-vaadin haijian-vaadin merged commit 9d98980 into vaadin:master Jan 29, 2021
@abdonrd abdonrd deleted the remove-bundle branch January 29, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platosha platosha platosha approved these changes

Assignees
No one assigned
Labels
hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for route.bundle and recommend using action
3 participants
@abdonrd @haijian-vaadin @platosha