Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Put Executor service into the application lookup #695

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

denis-anisimov
Copy link

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 14 issues

  • CRITICAL 5 critical
  • MAJOR 3 major
  • MINOR 6 minor

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL VaadinServletContextInitializer.java#L184: Move constants to a class or enum. rule
  2. CRITICAL VaadinServletContextInitializer.java#L803: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  3. CRITICAL VaadinServletContextInitializer.java#L817: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL VaadinServletContextInitializer.java#L824: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. CRITICAL VaadinServletContextInitializer.java#L830: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. MAJOR VaadinServletContextInitializer.java#L197: Define and throw a dedicated exception instead of using a generic one. rule
  7. MAJOR VaadinServletContextInitializer.java#L412: Define and throw a dedicated exception instead of using a generic one. rule
  8. MAJOR VaadinServletContextInitializer.java#L463: Define and throw a dedicated exception instead of using a generic one. rule
  9. MINOR VaadinServletContextInitializer.java#L701: Move this method into "RouteServletContextListener". rule
  10. MINOR VaadinServletContextInitializer.java#L709: Move this method into "WebComponentServletContextListener". rule

@caalador caalador changed the title fix: Put Executor service into the applicaiton lookup fix: Put Executor service into the application lookup Dec 7, 2020
@caalador caalador merged commit 8a376c2 into master Dec 7, 2020
@caalador caalador deleted the 9570-executor-rework branch December 7, 2020 09:27
manolo pushed a commit to vaadin/flow that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement fix for https://github.com/vaadin/spring/issues/691 via Lookup
4 participants