Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separation of unit tests into junit4/junit5 (#1363) #1558

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

MarcinVaadin
Copy link
Member

Description

Separation of vaadin-testbench-unit into three modules:

  • vaadin-testbench-unit-shared (common parts, no direct junit dependency)
  • vaadin-testbench-unit (junit4)
  • vaadin-testbench-unit-junit5 (junit5)

Fixes #1363

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@MarcinVaadin MarcinVaadin linked an issue Oct 24, 2022 that may be closed by this pull request
@mshabarov mshabarov merged commit f2c2e90 into master Oct 27, 2022
@mshabarov mshabarov deleted the chore/1363-separate-testbench-unit-tests-junit5 branch October 27, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider separate artifacts for JUnit 4 and JUnit 5
2 participants