fix!: Make Saucelabs integration use what Saucelabs recommends #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read tunnel identifier from sauce.tunnelId property or SAUCE_TUNNEL_ID env variable Note that this changes the default URL used for Sauce Labs from http://localhost:4445/wd/hub to the recommended https://ondemand.saucelabs.com/wd/hub. If you have an existing setup relying on the old Maven plugin, you might need to override getHubUrl to return the old URL This fix including a breaking change is needed since old sauce connect has EOL in Nov 2022 https://changelog.saucelabs.com/en/sauce-connect-proxy-reminder-end-of-life-dates
Artur-
previously approved these changes
Nov 25, 2022
According to Saucelabs support their Windows 7 browsers have some undefined problem with screenResolution so it is ignored
Artur-
previously approved these changes
Nov 25, 2022
Artur-
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read tunnel identifier from sauce.tunnelId property or SAUCE_TUNNEL_ID env variable
Note that this changes the default URL used for Sauce Labs from http://localhost:4445/wd/hub to the recommended https://ondemand.saucelabs.com/wd/hub. If you have an existing setup relying on the old Maven plugin, you might need to override getHubUrl to return the old URL
This fix including a breaking change is needed since old sauce connect has EOL in Nov 2022 https://changelog.saucelabs.com/en/sauce-connect-proxy-reminder-end-of-life-dates