Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changing Shortcuts.kts logic to use HashableKeys. #1616

Merged
merged 7 commits into from
Mar 16, 2023
Merged

fix: changing Shortcuts.kts logic to use HashableKeys. #1616

merged 7 commits into from
Mar 16, 2023

Commits on Mar 16, 2023

  1. As the ShortcutRegistration will always use HashableKeys, hencewhy we… 

    … need to use it in our tests as well to do not have any differences

within our tests and real life application. (now we used simple Key objects, but we need to use HashableKeys)
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cba86a9 View commit details
    Browse the repository at this point in the history

  2. Cleaned up the code a bit to use the HashableKey creation only in the… 

    … MockFilterJsonObject class.

(Based on @mcollovati  review, thank you)
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6f46413 View commit details
    Browse the repository at this point in the history

  3. Put the getHashableKey() method into the class (mock json), so where … 

    …we use it (suggestion by @mcollovati, thanks!).
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3dbac24 View commit details
    Browse the repository at this point in the history

  4. One more time, even nicer this way, like this one :) (Thanks again @m… 

    …collovati)
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    dca2daf View commit details
    Browse the repository at this point in the history

  5. Revert GridTester changes, and fix java doc for the newly added getHa… 

    …shableKey() method, fix imports.
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    ba892fc View commit details
    Browse the repository at this point in the history

  6. Using a bit more Kotlinish syntax for reflection (private inner class… 

    … constructor), and being more strict on that we are using ShortcutRegistration class. (discussed with @mcollovati that this could be a better way)
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3fbfd8b View commit details
    Browse the repository at this point in the history

  7. Enabling Shortcut related tests (were disabled by another dependency … 

    …FIX pr to merge it to master)
    @czp13
    czp13 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    29951fc View commit details
    Browse the repository at this point in the history