Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jakarta.annotation-api dependency to unit tests with test scope. #1617

Merged
merged 8 commits into from
Mar 16, 2023

Conversation

czp13
Copy link
Contributor

@czp13 czp13 commented Mar 16, 2023

Description

The flow-related changes from yesterday (many dependency got provided scope, made these compile errors in TestBench)

Fixing this issue:

https://teamcity.vaadin.com/buildConfiguration/VaadinTestbench_TestbenchPreCommitBuild[…]howLog=175662_915_111.937&logFilter=debug&logView=flowAware

Compiler
10:57:27 
    /opt/agent/work/ef9ade89d4c3cefd/vaadin-testbench-unit/src/test/java/com/testapp/security/ProtectedView.java:[11,35] package jakarta.annotation.security does not exist
    /opt/agent/work/ef9ade89d4c3cefd/vaadin-testbench-unit/src/test/java/com/testapp/security/ProtectedView.java:[20,2] cannot find symbol
      symbol: class PermitAll

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

This will be enabled in like very soon (10-20min) after this merged, because two PR-s blocking each other tests right now.
@ZheSun88 ZheSun88 enabled auto-merge (squash) March 16, 2023 12:59
@ZheSun88 ZheSun88 merged commit 390e53f into main Mar 16, 2023
@ZheSun88 ZheSun88 deleted the fix/java-annotation-dependency-compiler-error branch March 16, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants