Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: current year from 2022 -> 2023 (used in licenses) #1618

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: current year from 2022 -> 2023 (used in licenses) #1618

merged 1 commit into from
Mar 17, 2023

Conversation

czp13
Copy link
Contributor

@czp13 czp13 commented Mar 16, 2023 •
edited
Loading

Description

I just saw this along the way I worked in this project.

This is a fix from 2022 to 2023. This is used in
header.txt which is used in the license-maven-plugin. Not sure if we can have a problem because of 2022 legally, but better to fix this I feel.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@czp13
Fix from <currentYear>2022</currentYear> to <currentYear>2023</curren…
c3af132 
…tYear>. This is used in

header.txt wich is used in the license-maven-plugin. Not sure if we can have problem because of 2022 legally, but better to
fix this if I saw it.
@czp13 czp13 requested review from ZheSun88 and mshabarov March 16, 2023 14:41
@czp13 czp13 enabled auto-merge (squash) March 16, 2023 20:20
@czp13 czp13 merged commit 7acd848 into main Mar 17, 2023
@czp13 czp13 deleted the fix/current-year branch March 17, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

@ZheSun88 ZheSun88 Awaiting requested review from ZheSun88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czp13 @mshabarov