Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MultiSelectComboBoxTester #1662

Merged
merged 10 commits into from
Aug 29, 2023
Merged

Conversation

TatuLund
Copy link
Contributor

Part of #1635

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mcollovati
Copy link
Contributor

The current testbench version is compatible with Vaadin 24.0, that however does not contain MultiSelectComboBox (from 24.1)

@mshabarov
Copy link
Contributor

We can consider to release a new TestBench minor 9.1.0 and include this and this #1654 there. Then it can be used for Vaadin 24.1+

TatuLund and others added 3 commits August 14, 2023 20:40
Fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ZheSun88
Copy link
Contributor

ZheSun88 commented Aug 29, 2023

I added Tatu and his team in the collaboration.. it should work now, i think.
(well, i triggered the build manually this time)

mshabarov and others added 4 commits August 29, 2023 11:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mshabarov mshabarov merged commit df1a5b7 into vaadin:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants