Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature #1775 add support for lit renderers to grid tester #1776

Merged
merged 6 commits into from
Apr 9, 2024
Merged

feature #1775 add support for lit renderers to grid tester #1776

merged 6 commits into from
Apr 9, 2024

Conversation

joelpop
Copy link
Collaborator

@joelpop joelpop commented Mar 23, 2024

Description

LitRenderers in Grids can contain properties and functions, but have no way for them to be inspected or invoked, respectively.

This enhancement provides methods for the GridTester to support this capability.

Fixes #1775

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@joelpop joelpop requested review from Artur- and mcollovati March 23, 2024 04:06
@joelpop joelpop self-assigned this Mar 23, 2024
@joelpop
Overloaded tester methods to accept either columnName/Key or index.
68dee82 
Added tester method Javadoc comments.

Moved new LitRenderer column to BasicGridView test and tests to BasicGridTesterTest.

Updated impacted tests.
@joelpop joelpop requested a review from mshabarov March 23, 2024 22:18
joelpop added 2 commits April 8, 2024 21:48
@joelpop
Merge remote-tracking branch 'origin/main' into feature/#1775-Add-sup…
8b21423 
…port-for-LitRenderers-to-GridTester
@joelpop
Resolved PR refactorings:
d660e6b 
- updated comments
- made JsonArray a parameter
- changed type of thrown exception
@joelpop joelpop requested a review from mshabarov April 9, 2024 05:45
@mshabarov mshabarov merged commit 8ca9477 into main Apr 9, 2024
2 checks passed
@mshabarov mshabarov deleted the feature/#1775-Add-support-for-LitRenderers-to-GridTester branch April 9, 2024 06:43
@joelpop joelpop mentioned this pull request Apr 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

@Artur- Artur- Awaiting requested review from Artur-

@mcollovati mcollovati Awaiting requested review from mcollovati

Assignees

@joelpop joelpop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for LitRenderers to GridTester
2 participants
@joelpop @mshabarov