Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper for executing JavaScript #883

Merged
merged 4 commits into from
Jun 9, 2017
Merged

Add helper for executing JavaScript #883

merged 4 commits into from
Jun 9, 2017

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Mar 31, 2017

This change is Reviewable

@alvarezguille
Copy link
Member

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@alvarezguille
Copy link
Member

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


a discussion (no related file):
Maybe an example of this should be added to docs


Comments from Reviewable

@Artur-
Copy link
Member Author

Artur- commented May 12, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


a discussion (no related file):

Previously, alvarezguille (Guille) wrote…

Maybe an example of this should be added to docs

Of executing JS? Where would that go and what should it contain?


Comments from Reviewable

@Artur-
Copy link
Member Author

Artur- commented May 12, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


a discussion (no related file):

Previously, Artur- (Artur) wrote…

Of executing JS? Where would that go and what should it contain?

"Special Testing Topcis" -> "Executing Javascript" ?


Comments from Reviewable

@alvarezguille
Copy link
Member

a discussion (no related file):

Previously, Artur- (Artur) wrote…

"Special Testing Topcis" -> "Executing Javascript" ?

That looks like a good place yes


Comments from Reviewable

@svenruppert
Copy link
Contributor

Reviewed 3 of 3 files at r2.
Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@svenruppert
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@svenruppert
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, alvarezguille (Guille) wrote…

That looks like a good place yes

so far i saw it it was done..

ok


Comments from Reviewable

@svenruppert
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion.


a discussion (no related file):

Previously, svenruppert (Sven Ruppert) wrote…

so far i saw it it was done..

ok

ups.. dismissed be accident.. sorry


Comments from Reviewable

@Artur- Artur- merged commit 21317ff into master Jun 9, 2017
@Artur- Artur- deleted the execjs-helper branch June 9, 2017 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants