Skip to content

chore: fix running CRON tests in SauceLabs #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

chore: fix running CRON tests in SauceLabs #147

merged 1 commit into from
May 4, 2020

Conversation

web-padawan
Copy link
Member

Avoid running both "push" tests and CRON in the same build (see the most recent example).

@web-padawan web-padawan force-pushed the cron-fix branch 2 times, most recently from 6e4cf80 to f121a65 Compare April 27, 2020 07:33
Copy link
Contributor

@Haprog Haprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but did I understand correctly that the problem was that when "$TRAVIS_EVENT_TYPE" = "cron" it was running both wct --env saucelabs; and wct --env saucelabs-cron;?

Also this probably affects most of our components, not just vaadin-button so the change should be done everywhere. Should there be an issue/epic about this?

First I thought it should be done in vaadin-element-skeleton but then I noticed the master is already next-gen (Lit) and we don't even have a branch for current gen in it. I don't remember was there some reasoning behind it or should we create a branch and make this change there too? This would be needed only in case we still create some new components with current gen so we wouldn't have to checkout specific commit hash.

@web-padawan
Copy link
Member Author

Also this probably affects most of our components, not just vaadin-button so the change should be done everywhere. Should there be an issue/epic about this?

Added a comment to https://github.com/vaadin/components-team-tasks/issues/531#issuecomment-623317766 to keep all the fixes to CRON builds under the same issue. Will add a checklist with the components that need update.

@web-padawan
Copy link
Member Author

This would be needed only in case we still create some new components with current gen

I think the agreement was that we create new components using LitElement.

@web-padawan web-padawan merged commit abb8a52 into master May 4, 2020
@web-padawan web-padawan deleted the cron-fix branch May 4, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants