Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay should not close when clearing the field using the clear button #523

Closed
jouni opened this issue Sep 13, 2017 · 3 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jouni
Copy link
Member

jouni commented Sep 13, 2017

If the overlay was open when the user clears the field using the clear button, the overlay should not close.

Edit: I think we should actually open the overlay when the user clears the field using the button, if it was not open before (contrary to what I previously wrote).

@vicsstar
Copy link
Contributor

vicsstar commented Nov 7, 2017

@jouni 2 things.

  1. Going over the demos, I see that vaadin-combo-boxes don't have the clear button when there's no item selected. Is that's what's expected? Cause I think it impedes at least one of your comments above.
  2. When you edited your comment, were you insinuating that the former thing you said was no longer valid?

@jouni
Copy link
Member Author

jouni commented Nov 7, 2017

  1. Take a combo box which has a value, focus it -> the overlay opens -> click the clear button -> the overlay closes (it should not)
  2. I had previously written that the overlay should not open when pressing the clear button if the overlay is closed. But I changed my thoughts here, and think we should always open the dropdown when the user clears the value (as they are at the same time focusing the field with the mouse). Usually, it means the user is going to change it to something else, so we make it easier for them to pick another value.

@vicsstar
Copy link
Contributor

vicsstar commented Nov 7, 2017

Okay, I get it now; sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants