Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t open the overlay when clearing the field using the “clear” button #613

Closed
jouni opened this issue Feb 7, 2018 · 4 comments
Closed
Assignees

Comments

@jouni
Copy link
Member

jouni commented Feb 7, 2018

Proposal for discussion

The current behavior (focusing the field and opening the overlay) assumes the user would more often want to enter a new value when clearing the field.

A better assumption is that the user just wants to clear the field (common for filtering fields).

If they want to enter a new value, it’s more likely they will focus the field directly, and in that case, the overlay will open, so it’s quick to select another value from it.

The field should still become focused when pressing the “clear“ button with a mouse (current behavior). But, when pressing the “clear” button on a touch device, the field should not be focused to avoid the on-screen keyboard from popping up (which would be annoying when clearing filtering fields for example).

@jouni
Copy link
Member Author

jouni commented Feb 7, 2018

If we agree to change this, the same should be applied for vaadin-date-picker as well.

Also, eventually relevant: vaadin/vaadin-text-field#92

@web-padawan
Copy link
Member

This was implemented in #523 and some users were confused with the change, especially during UX test. One of the participants suggested to only open overlay again if the combo-box is required. So I'm happy with reverting this change, but I wish we could figure this out before beta 😞

@jouni
Copy link
Member Author

jouni commented Feb 8, 2018

This was implemented in #523 and some users were confused with the change, especially during UX test.

Yes, I’m to blame for being a little bullish on this, trying to force consistency at the expense of usability.

One of the participants suggested to only open overlay again if the combo-box is required

Don’t remember hearing that. I do remember hearing a suggestion that we should hide the clear button if a field is required, which encourages similar user behavior. As the developer can hide the clear button for required fields using a theme, I haven’t considered that as a must-have core feature.

So I'm happy with reverting this change, but I wish we could figure this out before beta

Completely agree. But better do it before final, right? 😉

If there’s consensus within the team, could someone prepare a PR, and we can have a quick test for it?

@jouni
Copy link
Member Author

jouni commented Feb 26, 2018

I’m currently under the assumption that we agree that this would be a change for the better.

@tomivirkki, this should then be done before the next beta, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants