Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The input box is enabled, and you can type in it #225

Closed
mercmobily opened this issue Aug 28, 2016 · 7 comments
Closed

The input box is enabled, and you can type in it #225

mercmobily opened this issue Aug 28, 2016 · 7 comments
Assignees
Milestone

Comments

@mercmobily
Copy link

This is seen in both Chrome and Firefox (both latest).

Create a standard element:

<vaadin-date-picker></vaadin-date-picker>

You will see that the following can be done:

1
2
3
4

Basically, I use the date picker ti pick a date. All good. Then in screenshot 3 you can see that I moved the cursor using the arrows. And then I typed CHANGED there.

There is another level to this bug. If you delete what's in the textbox, and then click on the date picker again and select the SAME date again, you will see that the textbox does NOT get restored -- since technically speaking the date hasn't changed.

This is a showstopper for us, since the app will be used from very computer illiterate people...! Happy to help with a PR for a fix -- please direct me a little in the code though...

@mercmobily
Copy link
Author

Actually, I am looking at the code, and I just cannot explain... why is there an input box at all...?

@mercmobily
Copy link
Author

mercmobily commented Aug 28, 2016

(Sorry, I had accidentally added the comment to the wrong issue, this is the right spot!)
Well... I might not need a pointer in the code after all.
It looks like just changing:

readonly$="[[readonly]]"

Into:

readonly

in vaadin-date-picker.html totally fixes the issue. And it makes a lot of sense too.
If it makes sense to you too, I will do a PR, But, it would me a monumental waste of noise, network, database entries in Github, and log entries in your git repo... you might as well just press backspace 16 times on your editor!

@jouni
Copy link
Member

jouni commented Aug 29, 2016

Actually, I am looking at the code, and I just cannot explain... why is there an input box at all...?

For two reasons, mainly. We wanted to use paper-input, so it needs and input field. Also, as we knew we wanted to have keyboard input at some point the future, we used an input already.

@mercmobily
Copy link
Author

Glad I could be of any help!

@mercmobily
Copy link
Author

Did you release the fix? It's kind of crucial.. if so, feel free to close this!

@tomivirkki
Copy link
Member

Hi @mercmobily,
There's a PR pending to be merged here #226 Already gave it thumbs up, but we still need to fix an issue with the test environment to get the merge finished.

@mercmobily
Copy link
Author

OK -- thanks for letting me know!

On 29 August 2016 at 20:16, Tomi Virkki notifications@github.com wrote:

Hi @mercmobily https://github.com/mercmobily,
There's a PR pending to be merged here #226
#226 Already gave it
thumbs up, but we still need to fix an issue with the test environment to
get the merge finished.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#225 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACB7XpdOoJfFHhZgyonN2OhWO5zo8gKyks5qks2YgaJpZM4Ju6ua
.

@jouni jouni removed the in review label Sep 2, 2016
@tehapo tehapo added this to the 1.1.4 milestone Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants