Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing of the overlay on clear-button click #498

Merged
merged 2 commits into from
Jan 4, 2018
Merged

Fix closing of the overlay on clear-button click #498

merged 2 commits into from
Jan 4, 2018

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jan 4, 2018 •
edited by manolo
Loading

Fixes #437

This change is Reviewable

@yuriy-fix yuriy-fix changed the title Fix/close button Fix closing of the overlay on clear-button click Jan 4, 2018
@web-padawan
Copy link
Member

:lgtm:

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@tomivirkki
Copy link
Member

:lgtm:

Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@tomivirkki tomivirkki merged commit 216f775 into master Jan 4, 2018
@tomivirkki tomivirkki deleted the fix/close-button branch January 4, 2018 13:45
@web-padawan web-padawan added this to the 3.0.0-alpha4 milestone Jan 5, 2018
@web-padawan web-padawan mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-alpha4
Development

Successfully merging this pull request may close these issues.
3 participants
@yuriy-fix @web-padawan @tomivirkki