-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click first cell child on space keyup #1739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes a lot of sense, considering that buttons normally get triggered on key up.
I just wonder if active-item
changes should follow the same pattern...
EDIT:
One weird behavior caused by using keydown
for changing active-item
: When you keep holding the space key down, the active-item
keeps toggling between null
and the focused item (because keydown
keeps on firing when the key is being held down).
I was thinking about that, but explicitly preserved the Active-item behavior is working this way on |
Yeah, I'm also a bit afraid to make this kind of changes... But I do think that the case is pretty much the same: To trigger an action, whether that is through a button's click listener or Thinking about the bug ticket, it might be also a valid use case that you want to open a confirm dialog for some action when "activating" the item anywhere in the row, instead of only via the button in one column. But if you'd open the confirm dialog on I also think that if changing the But I'm not sure about my personal opinion, whether this should be changed now or not... @tomivirkki, I would like to hear your opinion on this, or even more preferably the absolute truth. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A separate issue will be created for considering the case of activeItem
.
* Adjust test for space keyup * Click cell on space keyup * Enhance the test checking click is not fired on spaceDown
* Adjust test for space keyup * Click cell on space keyup * Enhance the test checking click is not fired on spaceDown
Fixes vaadin/vaadin-confirm-dialog-flow#120
Important note: Changes the grid behavior by clicking the cell on
Space
keyup. However cell is still "activated" onSpace
keydown.