Details broken when hidden

[christophe-g]

When a column is hidden , whatever is within if (index === columns.length - 1 && (this._rowDetailsTemplate || this.rowDetailsRenderer)) body is never called.

[tomivirkki]

I guess this fixes #1737?

[christophe-g]

@tomivirkki

I guess this fixes #1737?

Haha, likely so. I did not pay serious attention to this issue, as thought it was due to potential conflict with litElement.

[christophe-g]

But pushed in relation to #1753

[tomivirkki]

Also add a test case for the issue/fix here:

it('should not remove details row when a column is hidden', () => {
  grid.rowDetailsRenderer = root => root.textContent = 'row-details';
  grid.detailsOpenedItems = [grid._cache.items[0]];
  column.hidden = true;
  flushGrid(grid);
  const details = grid.shadowRoot.querySelector('#items [part~="details-cell"]')._content;
  expect(details.textContent).to.equal('row-details');
});

[christophe-g]

@tomivirkki - first time someone writes tests for me ! Appreciated.

[tomivirkki]

No problem :) This is quite a critical issue so the fix is also very much appreciated.

There still seems to be some white-space issue in the test file https://travis-ci.org/github/vaadin/vaadin-grid/jobs/697588806#L402