Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add JSDoc for attributes [skip ci] #1776

Merged
merged 3 commits into from
Jul 16, 2020
Merged

docs: add JSDoc for attributes [skip ci] #1776

merged 3 commits into from
Jul 16, 2020

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jul 16, 2020 •
edited
Loading

Fixes #1774

@web-padawan web-padawan requested a review from DiegoCardoso July 16, 2020 11:46
@web-padawan web-padawan mentioned this pull request Jul 16, 2020
Closed
20 tasks
DiegoCardoso
DiegoCardoso reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute that might be missing

vaadin-grid-data-provider-mixin

  • item-id-path

@web-padawan
Copy link
Member Author

item-id-path

Thanks, added.

@web-padawan web-padawan requested a review from DiegoCardoso July 16, 2020 13:37
DiegoCardoso
DiegoCardoso approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to look onto other files and it seems that we are better covered now.

@web-padawan web-padawan merged commit 20676fd into master Jul 16, 2020
@web-padawan web-padawan deleted the attr-jsdoc branch July 16, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSDoc to document attributes for camel case properties
2 participants
@web-padawan @DiegoCardoso