-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make explicit data request when clearing cache with no initial pool #2119
Conversation
Did some debugging with the original issue and this might be fixable in the data-provider-mixin: Seems that the It was never called... ...so added another one before the guard statement. It got caught a couple of times before the panel was opened, but also once after it got opened. All the other conditions were fine but The Seems that ...so it must have been The only place that sets it false is The end of But the condition here seems to be wrong since even though the grid has So one fix might be to change the condition to also make the explicit data request in case the initial pool hasn't been created: The PR's original revision works because it explicitly calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments related to the code style.
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
…ool (#2119) * fix: increase pool before clearing cache when sorting; add test * Enhance the fix by making explicit data request * Remove height condition * Move the test * Apply Serhii's suggestions Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> * Update test Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
…ool (#2119) (#2123) * fix: increase pool before clearing cache when sorting; add test * Enhance the fix by making explicit data request * Remove height condition * Move the test * Apply Serhii's suggestions Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> * Update test Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Fixes vaadin/flow-components#427