Flush debounceIncreasePool on loadPage if scrolling #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Feb 17, 2021
| @@ -345,7 +345,9 @@ | |||
| filters: this._mapFilters(), | |||
| parentItem: cache.parentItem | |||
| }; | |||
|
|
|||
| if (this.__scrollingToPendingIndex && this._debounceIncreasePool) { | |||
There was a problem hiding this comment.
This new __scrollingToPendingIndex property feels a bit hacky? Is there some other justification for adding it other than making that one data-provider test pass / should the increase pool debouncer not be flushed while the grid is scrolling to pending index?
I took a look at the failing test case and it seems to pass because of timing. If I wrap the last expect inside of a timeout of 1 second, it also fails on master due to a too large call count. I don't necessarily see it as a problem to increase the call count expectation to make the test pass with the new change in timing.
tulioag
force-pushed
the
fix/2107_TreeGrid_regression_since_14_4_3
branch
from
8c6c954 to
d9cb509
Compare
tomivirkki
approved these changes
Feb 18, 2021
tulioag
added a commit
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2107