chore: add lockfiles to ensure consistent builds in CI #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
web-padawan
force-pushed
the
chore/package-lock
branch
from
af55329 to
bb21203
Compare
tomivirkki
approved these changes
Jan 17, 2022
tomivirkki
force-pushed
the
chore/package-lock
branch
16 times, most recently
from
320f31c to
db58d83
Compare
tomivirkki
force-pushed
the
chore/package-lock
branch
from
db58d83 to
2e793c8
Compare
tomivirkki
reviewed
Jan 20, 2022
Comment on lines
+218
to
+235
| // Workaround a ShadyDOM bug | ||
| this._reorderGhost.hidden = true; | ||
|
|
||
| let cell; | ||
| if (Polymer.Settings.useShadow) { | ||
| if (this.shadowRoot.elementFromPoint) { | ||
| cell = this.shadowRoot.elementFromPoint(x, y); | ||
| } else { | ||
| cell = document.elementFromPoint(x, y); | ||
| } | ||
|
|
||
| // Workaround a FF58 bug | ||
| this._reorderGhost.hidden = false; | ||
|
|
||
| // Workaround FF58/ShadyDOM bugs | ||
| while (!cell._column && cell.parentElement) { | ||
| if (cell.localName === 'vaadin-grid-cell-content') { | ||
| cell = cell.assignedSlot.parentNode; | ||
| } else { | ||
| cell = cell.parentElement; |
There was a problem hiding this comment.
I eventually discovered a way to debug the failing tests locally. Turns out the failures were caused by issues in the elementFromPoint polyfill and also due to grid assuming elementFromPoint not being polyfilled at all (which was the case with older ShadyDOM). Phew...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connected to https://github.com/vaadin/components-team-tasks/issues/602
Depends on vaadin/magi-cli#158
Type of change