Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disabled property to grid (#3445) (CP: 14) #2211

Merged
merged 9 commits into from
Apr 4, 2022
Merged

feat: add disabled property to grid (#3445) (CP: 14) #2211

merged 9 commits into from
Apr 4, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Apr 1, 2022 •
edited
Loading

Description

The PR back-ports the grid disabled property feature to V14:

Fixes vaadin/web-components#2170

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vursen vursen changed the title feat: add disabled property to grid (#3445) feat: add disabled property to grid (#3445) (CP: 14) Apr 1, 2022
web-padawan
web-padawan approved these changes Apr 4, 2022
View reviewed changes
test/visual/test.js Outdated Show resolved Hide resolved
test/disabled.html Outdated Show resolved Hide resolved
@vursen vursen mentioned this pull request Apr 4, 2022
Merged
7 tasks
@vursen vursen force-pushed the feat/grid-disabled branch from 59ca900 to 28ad0d1 Compare April 4, 2022 12:29
@vursen vursen merged commit d183849 into master Apr 4, 2022
@vursen vursen deleted the feat/grid-disabled branch April 4, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[grid] Add disabled property
4 participants
@vursen @CLAassistant @sissbruecker @web-padawan