Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus item on click caused by Enter or Space keys #166

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes vaadin/web-components#7142

Based on vaadin/web-components#7111

Note: unlike the WC monorepo version (V22+), in V14 we have native <button> element handling click events, and we aren't calling click() manually on keydown. So I had to update tests to use enter() / space() followed by click().

Type of change

  • Bugfix

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@web-padawan web-padawan merged commit df2338d into master Feb 26, 2024
3 of 4 checks passed
@web-padawan web-padawan deleted the fix/keyboard-click-focus branch February 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14 - Disabled submenu is focused by keyboard actions
3 participants