Input element #24
Merged
Input element #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoobie
reviewed
Feb 11, 2021
Peppe
suggested changes
Feb 12, 2021
Comment on lines
+2
to
+5
| import '@vaadin/vaadin-lumo-styles/color.js'; | ||
| import '@vaadin/vaadin-lumo-styles/sizing.js'; | ||
| import '@vaadin/vaadin-lumo-styles/spacing.js'; | ||
| import '@vaadin/vaadin-lumo-styles/style.js'; |
There was a problem hiding this comment.
Do we have some convention that should all of these be imported always or only those that you refer to in the same file? Spacing seems to be the only one in use below.
Peppe
suggested changes
Feb 12, 2021
Peppe
suggested changes
Feb 12, 2021
Peppe
previously requested changes
Feb 12, 2021
pekam
reviewed
Feb 15, 2021
web-padawan
requested changes
Feb 15, 2021
package.json
Outdated
| "@vaadin/vaadin-element-mixin": "^2.4.1", | ||
| "@vaadin/vaadin-lumo-styles": "^1.6.1", | ||
| "@vaadin/vaadin-material-styles": "^1.3.2", | ||
| "@vaadin/vaadin-text-field": "^3.0.0", |
There was a problem hiding this comment.
Please use ^2.8.0 if you want the component to be compatible with Vaadin 14.x
src/vaadin-message-input.js
Outdated
Comment on lines
71
to
78
| static get is() { | ||
| return 'vaadin-message-input'; | ||
| } | ||
|
|
||
| static get version() { | ||
| return '1.0.0-alpha1'; | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: please place these getters after static get template and before ready method.
That's the convention that we follow in other components.
Co-authored-by: Pekka Maanpää <pekkamaa@vaadin.com>
To be Vaadin 14 compatible.
These didn't come automatically via text-area anymore after downgrade from 3.0 to 2.8
web-padawan
approved these changes
Feb 15, 2021
It was allready deleted in the actual class.
pekam
approved these changes
Feb 16, 2021
Peppe
dismissed
their stale review
Dismissing my own review as I took over fixing the review issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that need to be configurable: