Use CSS variables to set vaadin-button lumo colors #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables vaadin-button styles to be applied for buttons that are not direct children of the vaadin-notification-card. Fixes #104
to have the added css properties
pekam
force-pushed
the
button-color-variables
branch
2 times, most recently
from
14c4045 to
3d2579f
Compare
pekam
force-pushed
the
button-color-variables
branch
2 times, most recently
from
f34c65b to
32db786
Compare
pekam
force-pushed
the
button-color-variables
branch
from
32db786 to
86d7202
Compare
It passes locally on IE11 but fails on CI
to allow not testing the ShadyCSS workaround
tomivirkki
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables vaadin-button styles to be applied for buttons that are
not direct children of the vaadin-notification-card.
This requires vaadin-button 2.2
Fix #104
This change is