This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Add demos to ordered layout demos (#146) #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anasmi
commented
Jun 30, 2020
anasmi
commented
- Adding demos to ordered layout demos
* Adding demos to ordered layout demos
vaadin-bot
reviewed
Jun 30, 2020
| // end-source-example | ||
|
|
||
| layout.getStyle().set("border", "1px solid #9E9E9E"); | ||
| component1.getElement().getStyle().set("height", "fit-content"); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jun 30, 2020
| @@ -292,6 +311,8 @@ private void createHorizontalLayoutWithDefaultAlignment() { | |||
| Component component3 = createComponent(3, "#37474F"); | |||
|
|
|||
| layout.add(component1, component2, component3); | |||
|
|
|||
| add(layout); | |||
| // end-source-example | |||
|
|
|||
| component2.getElement().getStyle().set("fontSize", "24px"); | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 19 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
tmattsso
approved these changes
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.