-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextArea does not explicitly implement HasHelper. The other fields are implementing this interface.
TextArea, as in other fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, but some minor issues (and some extra comments that don't require action right now).
...xt-field-flow-demo/src/main/java/com/vaadin/flow/component/textfield/demo/TextFieldView.java
Outdated
Show resolved
Hide resolved
...xt-field-flow-demo/src/main/java/com/vaadin/flow/component/textfield/demo/TextFieldView.java
Outdated
Show resolved
Hide resolved
...tegration-tests/src/test/java/com/vaadin/flow/component/textfield/tests/TextFieldPageIT.java
Outdated
Show resolved
Hide resolved
...n-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/AbstractNumberField.java
Outdated
Show resolved
Hide resolved
...low-testbench/src/main/java/com/vaadin/flow/component/textfield/testbench/HasHelperText.java
Show resolved
Hide resolved
This PR is ready but should only be merged after #261 (and after 2.1 stable has been released from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as blocked for now to try and avoid accidentally merging this too soon (see my above comment).
vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextArea.java
Show resolved
Hide resolved
vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/PasswordField.java
Show resolved
Hide resolved
vaadin-text-field-flow/src/main/java/com/vaadin/flow/component/textfield/TextField.java
Show resolved
Hide resolved
SonarQube analysis reported 35 issues Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
This reverts commit 8c80284. This is available in 2.2 branch but not in master (3.0 soon).
This reverts commit 8c80284.
Added API for setting
helper-text
attribute, and adding components tohelper
slotThis change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)