Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Added API for helper text #242

Merged
merged 21 commits into from
Nov 28, 2019
Merged

Added API for helper text #242

merged 21 commits into from
Nov 28, 2019

Conversation

onuridrisoglu
Copy link
Contributor

@onuridrisoglu onuridrisoglu commented Oct 15, 2019

Added API for setting helper-text attribute, and adding components to helper slot


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@jcgueriaud1 jcgueriaud1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextArea does not explicitly implement HasHelper. The other fields are implementing this interface.

@Haprog
Copy link
Contributor

Haprog commented Oct 24, 2019

@Haprog Haprog self-requested a review November 7, 2019 13:24
@Haprog Haprog self-assigned this Nov 7, 2019
Copy link
Contributor

@Haprog Haprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, but some minor issues (and some extra comments that don't require action right now).

@Haprog
Copy link
Contributor

Haprog commented Nov 12, 2019

This PR is ready but should only be merged after #261 (and after 2.1 stable has been released from master) since that other one is targeting V14.1 (vaadin-text-field 2.5.x, Flow component 2.1) and this PR bumps the WC version to 2.6.0-alpha1 and should bump this Flow component master to 2.2 (targeting V15 and V14.2).

Copy link
Contributor

@Haprog Haprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as blocked for now to try and avoid accidentally merging this too soon (see my above comment).

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 35 issues

  • BLOCKER 4 blocker
  • CRITICAL 9 critical
  • MAJOR 7 major
  • MINOR 15 minor

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. BLOCKER TextArea.java#L329: Rename method "setMaxLength" to prevent any misunderstanding/clash with method "setMaxlength" defined in superclass "com.vaadin.flow.component.textfield.GeneratedVaadinTextArea". rule
  2. BLOCKER TextArea.java#L351: Rename method "setMinLength" to prevent any misunderstanding/clash with method "setMinlength" defined in superclass "com.vaadin.flow.component.textfield.GeneratedVaadinTextArea". rule
  3. BLOCKER TextField.java#L330: Rename method "setMaxLength" to prevent any misunderstanding/clash with method "setMaxlength" defined in superclass "com.vaadin.flow.component.textfield.GeneratedVaadinTextField". rule
  4. BLOCKER TextField.java#L352: Rename method "setMinLength" to prevent any misunderstanding/clash with method "setMinlength" defined in superclass "com.vaadin.flow.component.textfield.GeneratedVaadinTextField". rule
  5. CRITICAL TextFieldView.java#L93: Define a constant instead of duplicating this literal "Label" 4 times. rule
  6. CRITICAL TextFieldView.java#L99: Define a constant instead of duplicating this literal "Value" 4 times. rule
  7. CRITICAL TextFieldView.java#L107: Define a constant instead of duplicating this literal "Text field" 7 times. rule
  8. CRITICAL TextFieldView.java#L232: Define a constant instead of duplicating this literal "Number field" 6 times. rule
  9. CRITICAL TextFieldView.java#L312: Define a constant instead of duplicating this literal "Description" 3 times. rule
  10. CRITICAL TextFieldView.java#L313: Define a constant instead of duplicating this literal "Write here ..." 3 times. rule

@Haprog Haprog merged commit 8c80284 into master Nov 28, 2019
@Haprog Haprog deleted the feature/helper-text branch November 28, 2019 11:19
pleku added a commit that referenced this pull request Jan 16, 2020
This reverts commit 8c80284.

This is available in 2.2 branch but not in master (3.0 soon).
pleku added a commit that referenced this pull request Jan 16, 2020
This reverts commit 8c80284.

This is available in 2.2 branch but not in master (3.0 soon).
alvarezguille added a commit that referenced this pull request May 27, 2020
alvarezguille added a commit that referenced this pull request May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants