This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Add Helper API #101
Merged
Add Helper API #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DiegoCardoso
suggested changes
Jul 14, 2020
added 2 commits
August 19, 2020 15:15
- Component version `2.4.0-alpha1` - Implement `HasHelper` interface - Bump version number by 0.1 - Created tests - Add demo Current PR has a client-side error: `vaadin-item` has been already defined Fixes #96
tomivirkki
force-pushed
the
feat/2.2-helper-API
branch
from
4a8e054 to
6c819fd
Compare
vaadin-bot
reviewed
Aug 21, 2020
vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java
Show resolved
Hide resolved
vaadin-bot
reviewed
Aug 21, 2020
...tegration-tests/src/main/java/com/vaadin/flow/component/timepicker/tests/TimePickerPage.java
Show resolved
Hide resolved
vaadin-bot
reviewed
Aug 21, 2020
...tegration-tests/src/main/java/com/vaadin/flow/component/timepicker/tests/TimePickerPage.java
Show resolved
Hide resolved
tomivirkki
approved these changes
Aug 21, 2020
|
SonarQube analysis reported 24 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
DiegoCardoso
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.4.0-alpha1HasHelperinterfaceCurrent PR has a client-side error:
vaadin-itemhas been already definedFixes #96