revert no longer necessary changes

vaadin · Dec 13, 2024 · 2fe269c · 2fe269c
1 parent b150337
commit 2fe269c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 19 deletions.
diff --git a/packages/form-layout/src/vaadin-form-item-mixin.js b/packages/form-layout/src/vaadin-form-item-mixin.js
@@ -42,14 +42,6 @@ export const FormItemMixin = (superClass) =>
       this.__fieldNode = null;
     }
 
-    connectedCallback() {
-      super.connectedCallback();
-
-      if (this.performUpdate) {
-        this.performUpdate();
-      }
-    }
-
     /**
      * Returns a target element to add ARIA attributes to for a field.
      *

diff --git a/packages/form-layout/src/vaadin-form-layout-mixin.js b/packages/form-layout/src/vaadin-form-layout-mixin.js
@@ -141,10 +141,6 @@ export const FormLayoutMixin = (superClass) =>
     connectedCallback() {
       super.connectedCallback();
 
-      if (this.performUpdate) {
-        this.performUpdate();
-      }
-
       requestAnimationFrame(() => this._selectResponsiveStep());
       requestAnimationFrame(() => this._updateLayout());
 

diff --git a/packages/form-layout/test/form-item.common.js b/packages/form-layout/test/form-item.common.js
@@ -10,14 +10,13 @@ describe('form-item', () => {
   describe('basic features', () => {
     let labelSlot, inputSlot;
 
-    beforeEach(async () => {
+    beforeEach(() => {
       item = fixtureSync(`
         <vaadin-form-item>
           <label slot="label">Label</label>
           <input>
         </vaadin-form-item>
       `);
-      await nextFrame();
       label = item.querySelector('label');
       input = item.querySelector('input');
       labelSlot = item.shadowRoot.querySelector('slot[name="label"]');
@@ -39,14 +38,13 @@ describe('form-item', () => {
   });
 
   describe('label positioning', () => {
-    beforeEach(async () => {
+    beforeEach(() => {
       item = fixtureSync(`
         <vaadin-form-item>
           <label slot="label">Label</label>
           <input>
         </vaadin-form-item>
       `);
-      await nextFrame();
       label = item.querySelector('label');
       input = item.querySelector('input');
     });
@@ -86,7 +84,6 @@ describe('form-item', () => {
     beforeEach(async () => {
       const item1 = fixtureSync(`<vaadin-form-item><label slot="label">Label</label></vaadin-form-item>`);
       const item2 = fixtureSync(`<vaadin-form-item><label slot="label">Label</label></vaadin-form-item>`);
-      await nextFrame();
       label1 = item1.querySelector('label');
       label2 = item2.querySelector('label');
       await nextFrame();
@@ -314,14 +311,13 @@ describe('form-item', () => {
       document.body.removeChild(testInput);
     });
 
-    beforeEach(async () => {
+    beforeEach(() => {
       item = fixtureSync(`
         <vaadin-form-item>
           <label slot="label">Label</label>
           <input>
         </vaadin-form-item>
       `);
-      await nextFrame();
       label = item.querySelector('label');
       input = item.querySelector('input');
       item.style.width = '100%';