refactor: use native Tab order when leaving popover content

vaadin · Jul 31, 2024 · 50b7f25 · 50b7f25
1 parent 85ab3b9
commit 50b7f25
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/packages/popover/src/vaadin-popover.js b/packages/popover/src/vaadin-popover.js
@@ -610,8 +610,7 @@ class Popover extends PopoverPositionMixin(
     if (lastFocusable && isElementFocused(lastFocusable)) {
       const focusable = this.__getNextBodyFocusable(this.target);
       if (focusable && focusable !== overlayPart) {
-        event.preventDefault();
-        focusable.focus();
+        this.target.focus();
         return;
       }
     }

diff --git a/packages/popover/test/a11y.test.js b/packages/popover/test/a11y.test.js
@@ -351,12 +351,10 @@ describe('a11y', () => {
       // Move focus to the input inside the overlay
       await sendKeys({ press: 'Tab' });
 
-      const spy = sinon.spy(input, 'focus');
-
       // Move focus to the input after the overlay
       await sendKeys({ press: 'Tab' });
 
-      expect(spy).to.be.calledOnce;
+      expect(document.activeElement).to.equal(input);
     });
 
     it('should focus the last overlay child on the next element Shift Tab', async () => {